Skip to content

fix(internal): call ruff with correct args #3901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2024
Merged

fix(internal): call ruff with correct args #3901

merged 1 commit into from
Mar 7, 2024

Conversation

rubenfonseca
Copy link
Contributor

Issue number: #3899

Summary

Changes

Please provide a summary of what's being changed

This PR removes the warning when invoking ruff, by adding the new required check parameter.

User experience

Please share what the user experience looks like before and after this change

The warning is no longer present.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@rubenfonseca rubenfonseca requested a review from a team March 7, 2024 13:57
@boring-cyborg boring-cyborg bot added the internal Maintenance changes label Mar 7, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 7, 2024
@rubenfonseca rubenfonseca linked an issue Mar 7, 2024 that may be closed by this pull request
2 tasks
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions github-actions bot added bug Something isn't working and removed internal Maintenance changes labels Mar 7, 2024
@rubenfonseca rubenfonseca merged commit e32cbab into develop Mar 7, 2024
@rubenfonseca rubenfonseca deleted the rf/3899 branch March 7, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: ruff needs a new parameter "check"
2 participants